Skip to content

fix: get the right chunk name for preserve modules in Windows#5625

Merged
lukastaegert merged 3 commits intomasterfrom
fix/5620
Aug 26, 2024
Merged

fix: get the right chunk name for preserve modules in Windows#5625
lukastaegert merged 3 commits intomasterfrom
fix/5620

Conversation

@TrickyPi
Copy link
Copy Markdown
Member

@TrickyPi TrickyPi commented Aug 25, 2024 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5620

Description

remove the Windows drive prefix if the inputBase is /.

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 3:22pm

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 25, 2024 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/5620

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-qvmvqd5b5-rollup-js.vercel.app/repl/?pr=5625

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.04%. Comparing base (c1d25d6) to head (17083d0).
Report is 2 commits behind head on master.

Files Patch % Lines
src/Chunk.ts 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5625      +/-   ##
==========================================
- Coverage   99.05%   99.04%   -0.02%     
==========================================
  Files         242      242              
  Lines        9325     9329       +4     
  Branches     2466     2467       +1     
==========================================
+ Hits         9237     9240       +3     
- Misses         57       58       +1     
  Partials       31       31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 25, 2024 •
edited
Loading

Performance report!

Rough benchmark

Command Mean [s] Min [s] Max [s] Relative
node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js 9.523 ± 0.026 9.499 9.552 1.00
node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js 9.550 ± 0.083 9.464 9.628 1.00 ± 0.01

Internal benchmark

  • BUILD: 8483ms, 752 MB
    • initialize: 0ms, 25.9 MB
    • generate module graph: 3254ms, 575 MB
      • generate ast: 1540ms, 568 MB
    • sort and bind modules: 466ms, 616 MB
    • mark included statements: 4762ms, 752 MB
      • treeshaking pass 1: 1616ms, 718 MB
      • treeshaking pass 2: 779ms, 741 MB
      • treeshaking pass 3: 306ms, 745 MB
      • treeshaking pass 4: 282ms, 748 MB
      • treeshaking pass 5: 329ms, 751 MB
      • treeshaking pass 6: 269ms, 752 MB
      • treeshaking pass 7: 252ms, 753 MB
      • treeshaking pass 8: 245ms, 751 MB
      • treeshaking pass 9: 221ms, 754 MB
      • treeshaking pass 10: 226ms, 752 MB
      • treeshaking pass 11: 219ms, 752 MB
  • GENERATE: 925ms, 1.02 GB
    • initialize render: 0ms, 914 MB
    • generate chunks: 91ms, 926 MB
      • optimize chunks: 0ms, 917 MB
    • render chunks: 812ms, 1 GB
    • transform chunks: 19ms, 1.02 GB
    • generate bundle: 0ms, 1.02 GB

lukastaegert
lukastaegert reviewed Aug 26, 2024
View reviewed changes
@lukastaegert lukastaegert merged commit fadebcd into master Aug 26, 2024
@lukastaegert lukastaegert deleted the fix/5620 branch August 26, 2024 15:27
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 26, 2024

This PR has been released as part of rollup@4.21.1. You can test it via npm install rollup.

@github-actions github-actions bot mentioned this pull request Aug 26, 2024
Closed
@leonardoadame leonardoadame mentioned this pull request Sep 17, 2024
Open
This was referenced Sep 17, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 19, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 20, 2024
Open
This was referenced Sep 21, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 22, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Sep 23, 2024
Open
This was referenced Sep 23, 2024
Open
Open
Open
This was referenced Sep 25, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 2, 2024
Open
Open
This was referenced Oct 4, 2024
Open
Open
@YashGovekar YashGovekar mentioned this pull request Oct 4, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Oct 4, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Oct 5, 2024
Open
This was referenced Oct 13, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid substitution for placeholder "[name]" error happens when a resolved id starts with / and preserveModules: true is set on Windows

2 participants

@TrickyPi @lukastaegert