Skip to content

feat: introduce the virtualDirname option to customize the virtual directory name#5602

Merged
lukastaegert merged 1 commit intomasterfrom
feat/dynamic-virtual-location
Aug 16, 2024
Merged

feat: introduce the virtualDirname option to customize the virtual directory name#5602
lukastaegert merged 1 commit intomasterfrom
feat/dynamic-virtual-location

Conversation

@TrickyPi
Copy link
Copy Markdown
Member

@TrickyPi TrickyPi commented Aug 3, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5563

Description

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2024 1:28pm

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 3, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#feat/dynamic-virtual-location

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-gcaxhpi1x-rollup-js.vercel.app/repl/?pr=5602

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 3, 2024

Performance report!

Rough benchmark

Command Mean [s] Min [s] Max [s] Relative
node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js 9.307 ± 0.191 9.110 9.492 1.00
node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js 9.425 ± 0.122 9.347 9.566 1.01 ± 0.02

Internal benchmark

  • BUILD: 8018ms, 752 MB
    • initialize: 0ms, 26 MB
    • generate module graph: 3076ms, 574 MB
      • generate ast: 1499ms, 567 MB
    • sort and bind modules: 443ms, 613 MB
    • mark included statements: 4492ms, 752 MB
      • treeshaking pass 1: 1521ms, 718 MB
      • treeshaking pass 2: 729ms, 742 MB
      • treeshaking pass 3: 285ms, 746 MB
      • treeshaking pass 4: 267ms, 743 MB
      • treeshaking pass 5: 312ms, 751 MB
      • treeshaking pass 6: 254ms, 752 MB
      • treeshaking pass 7: 238ms, 748 MB
      • treeshaking pass 8: 232ms, 749 MB
      • treeshaking pass 9: 212ms, 755 MB
      • treeshaking pass 10: 214ms, 752 MB
      • treeshaking pass 11: 211ms, 752 MB
  • GENERATE: 862ms, 1.02 GB
    • initialize render: 0ms, 913 MB
    • generate chunks: 82ms, 919 MB
      • optimize chunks: 0ms, 916 MB
    • render chunks: 762ms, 1 GB
    • transform chunks: 17ms, 1.02 GB
    • generate bundle: 0ms, 1.02 GB

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.05%. Comparing base (df12edf) to head (290e1b7).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5602   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         242      242           
  Lines        9311     9312    +1     
  Branches     2466     2467    +1     
=======================================
+ Hits         9223     9224    +1     
  Misses         58       58           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@lukastaegert lukastaegert added this pull request to the merge queue Aug 16, 2024
Merged via the queue into master with commit af6a347 Aug 16, 2024
@lukastaegert lukastaegert deleted the feat/dynamic-virtual-location branch August 16, 2024 06:37
@github-actions
Copy link
Copy Markdown

This PR has been released as part of rollup@4.21.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web extensions built using --preserveModules cannot be installed

2 participants