fix: only optimize annoymous iife#5486
Merged
lukastaegert merged 4 commits intorollup:masterfrom Apr 23, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sparecycles
reviewed
Apr 23, 2024
Contributor
sparecycles
left a comment
There was a problem hiding this comment.
lgtm, I think? (Don't take my word for it, I'm new here!)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5486 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 238 238
Lines 9560 9563 +3
Branches 2444 2446 +2
=======================================
+ Hits 9449 9452 +3
Misses 46 46
Partials 65 65 ☔ View full report in Codecov by Sentry. |
|
This PR has been released as part of rollup@4.16.3. You can test it via |
9 tasks
This was referenced May 21, 2024
This was referenced Jul 30, 2024
This was referenced Aug 2, 2024
This was referenced Aug 9, 2024
This was referenced Aug 11, 2024
This was referenced Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
If a IIFE has a name, it may lose track. In this case we probably should not consider to optimize them.