Skip to content

Fix ppc64le target#5460

Merged
lukastaegert merged 1 commit intomasterfrom
fix-ppc64le
Apr 10, 2024
Merged

Fix ppc64le target#5460
lukastaegert merged 1 commit intomasterfrom
fix-ppc64le

Conversation

@lukastaegert
Copy link
Copy Markdown
Member

@lukastaegert lukastaegert commented Apr 8, 2024

See also https://nodejs.org/api/process.html#processarch

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

While the actual target is ppc64le, it is called ppc64 in Node's process.arch

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 4:48am

@lukastaegert lukastaegert mentioned this pull request Apr 8, 2024
Merged
9 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2024 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-ppc64le

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-jbvt3cn40-rollup-js.vercel.app/repl/?pr=5460

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.79%. Comparing base (0b665c3) to head (a86e2bb).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5460   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files         238      238           
  Lines        9449     9449           
  Branches     2407     2407           
=======================================
  Hits         9335     9335           
  Misses         48       48           
  Partials       66       66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit b957e1d into master Apr 10, 2024
@lukastaegert lukastaegert deleted the fix-ppc64le branch April 10, 2024 04:49
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2024

This PR has been released as part of rollup@4.14.2. You can test it via npm install rollup.

@leonardoadame leonardoadame mentioned this pull request May 19, 2024
Open
@YashGovekar YashGovekar mentioned this pull request May 19, 2024
Open
@x-way x-way mentioned this pull request May 20, 2024
Closed
@leonardoadame leonardoadame mentioned this pull request May 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lukastaegert