Skip to content

Handle pure annotations that are separated by a comment#5332

Merged
lukastaegert merged 1 commit intomasterfrom
gh-5324_pure_annotations_before_comment
Jan 6, 2024
Merged

Handle pure annotations that are separated by a comment#5332
lukastaegert merged 1 commit intomasterfrom
gh-5324_pure_annotations_before_comment

Conversation

@lukastaegert
Copy link
Copy Markdown
Member

@lukastaegert lukastaegert commented Jan 5, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This extends the annotation logic to handle comments that separate annotations from the annotated code.

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview Jan 5, 2024 6:49am

@lukastaegert lukastaegert mentioned this pull request Jan 5, 2024
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2024 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-5324_pure_annotations_before_comment

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-aum8bg5at-rollup-js.vercel.app/repl/?pr=5332

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ab3ad3) 98.81% compared to head (4c19872) 98.81%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5332   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         232      232           
  Lines        8981     8981           
  Branches     2341     2341           
=======================================
  Hits         8875     8875           
  Misses         46       46           
  Partials       60       60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit c249413 into master Jan 6, 2024
@lukastaegert lukastaegert deleted the gh-5324_pure_annotations_before_comment branch January 6, 2024 05:55
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 6, 2024

This PR has been released as part of rollup@4.9.4. You can test it via npm install rollup.

@philihp philihp mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

babel pure annotation output with leading comments not supported

1 participant

@lukastaegert