Allow function expression parameters to shadow the function id#5262
Allow function expression parameters to shadow the function id#5262lukastaegert merged 3 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-5259-duplicate-function-idNotice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5262 +/- ##
=======================================
Coverage 98.87% 98.87%
=======================================
Files 232 232
Lines 8941 8945 +4
Branches 2333 2334 +1
=======================================
+ Hits 8840 8844 +4
Misses 42 42
Partials 59 59 ☔ View full report in Codecov by Sentry. |
|
This PR has been released as part of rollup@4.5.1. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
In order for the new conflict detection logic to work, function expression ids need to be in a separate scope from the parameters.