Skip to content

fix: allow the name of Rollup Error to be modified#5240

Merged
lukastaegert merged 2 commits intomasterfrom
xiaopi-uncaught-errors
Nov 10, 2023
Merged

fix: allow the name of Rollup Error to be modified#5240
lukastaegert merged 2 commits intomasterfrom
xiaopi-uncaught-errors

Conversation

@TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Nov 7, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Recently, I use Rollup and @rollup/plugin-typescript(the tsconfig noEmitOnError is true) plugin to bundle my project, I found that the error content is incorrect if this plugin throws an error by calling this.error function under watch mode.

The incorrect error.
1

Therefore, I submitted this PR that allows the name of the Rollup Error to be modified.

@vercel
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 8:12am

@codecov
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #5240 (ccb097d) into master (ac32f83) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5240      +/-   ##
==========================================
+ Coverage   98.80%   98.82%   +0.02%     
==========================================
  Files         231      231              
  Lines        8863     8863              
  Branches     2317     2317              
==========================================
+ Hits         8757     8759       +2     
+ Misses         45       43       -2     
  Partials       61       61              
Files Coverage Δ
src/utils/logs.ts 97.66% <100.00%> (ø)

... and 1 file with indirect coverage changes

@github-actions
Copy link

github-actions bot commented Nov 7, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#xiaopi-uncaught-errors

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-93y07mbiz-rollup-js.vercel.app/repl/?pr=5240

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@lukastaegert lukastaegert added this pull request to the merge queue Nov 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 10, 2023
@lukastaegert lukastaegert added this pull request to the merge queue Nov 10, 2023
Merged via the queue into master with commit ef3be44 Nov 10, 2023
@lukastaegert lukastaegert deleted the xiaopi-uncaught-errors branch November 10, 2023 08:31
@github-actions
Copy link

This PR has been released as part of rollup@4.3.1. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants