perf(sourcemaps): add back lazy sourcemap decode and handling nullish mappings#5087
Merged
lukastaegert merged 3 commits intorollup:masterfrom Aug 9, 2023
Merged
Conversation
Adding back the improvements from rollup#5075
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #5087 +/- ##
==========================================
- Coverage 98.97% 98.96% -0.01%
==========================================
Files 226 226
Lines 8362 8390 +28
Branches 2294 2303 +9
==========================================
+ Hits 8276 8303 +27
Misses 31 31
- Partials 55 56 +1
|
a32fc7e to
be5f635
Compare
9 tasks
Contributor
Author
|
@lukastaegert Sorry to ping you, but can this be merged and re-released if the change looks good? Bug fix is in the second commit to make it clearer what the problem was, but feel free to squash and merge if you'd like. |
Member
|
Ah sorry, thanks for reminding me, I will take care. |
lukastaegert
approved these changes
Aug 9, 2023
Collaborator
|
This PR has been released as part of rollup@3.28.0. You can test it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #5084
Description
We weren't properly handling ill-formed (according to types) sourcemap input such as
{mappings: null}{mappings: undefined}or{}. This PR expands the set of values that can be passed in todecodedSourcemapsto ensure that we are handling all those edge cases and doing something sane. In this case, we treatmappings: nullthe same asmappings: ''and return the "empty sourcemap"