Prevent using "arguments" for generated variable names#4613
Merged
lukastaegert merged 1 commit intomasterfrom Aug 19, 2022
Merged
Prevent using "arguments" for generated variable names#4613lukastaegert merged 1 commit intomasterfrom
lukastaegert merged 1 commit intomasterfrom
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4612-no-arguments-as-variableor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4613 +/- ##
=======================================
Coverage 98.87% 98.87%
=======================================
Files 209 209
Lines 7366 7368 +2
Branches 2102 2103 +1
=======================================
+ Hits 7283 7285 +2
Misses 27 27
Partials 56 56
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #4612
Description
While "arguments" is not a reserved word in JavaScript, it cannot be used for declaring variables in strict mode, so this adds some special logic to prevent this.