use void for options hook instead of undefined#4463
Merged
lukastaegert merged 3 commits intorollup:masterfrom Apr 15, 2022
Merged
use void for options hook instead of undefined#4463lukastaegert merged 3 commits intorollup:masterfrom
lukastaegert merged 3 commits intorollup:masterfrom
Conversation
currently we are required to return in the options hook. this change would allow the options hook to have no return value.
lukastaegert
approved these changes
Apr 15, 2022
Member
lukastaegert
left a comment
There was a problem hiding this comment.
Good point, the intention is actually to allow you not to write a return. I also changed this for the other hooks.
Codecov Report
@@ Coverage Diff @@
## master #4463 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 205 205
Lines 7326 7326
Branches 2079 2079
=======================================
Hits 7236 7236
Misses 33 33
Partials 57 57
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
Description
currently we are required to return
undefinedin the options hook when using TS. this change would allow the options hook to have no return value.