Deprecate hasModuleSideEffects in favor of moduleSideEffects and ensure it is mutable on ModuleInfo#4379
Merged
lukastaegert merged 2 commits intomasterfrom Feb 2, 2022
Merged
Conversation
…re it is mutable on ModuleInfo
77d9b4a to
10f22ad
Compare
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#mutable-module-side-effectsor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4379 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 205 205
Lines 7311 7318 +7
Branches 2083 2083
=======================================
+ Hits 7218 7225 +7
Misses 34 34
Partials 59 59
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This fixes an inconsistency in the naming i.e. we are using the
moduleSideEffectsoption in theresolveId,loadandtransformhooks, but onModuleInfoit is calledhasModuleSideEffects. This becomes more problematic if you want to change this property explicitly onModuleInfo.This PR does several things:
moduleSideEffectsonModuleInfo(e.g. viathis.getModuleInfo()) that takes the role ofhasModuleSideEffectshasModuleSideEffectsandstrictDeprecationsistruehasModuleSideEffectsnon-enumerable to avoid accidentally triggering the warning and basically hide the old option (though it still works to prevent breaking changes)moduleSideEffectscan be written during build time, which is important if you write e.g. an entry point proxy plugin that needs to set this flag totruefor the original entry point (I also updated theinject-polyfillexample in the docs to reflects this)