Ignore queries and hashes in file names when preserving modules#4374
Merged
lukastaegert merged 2 commits intomasterfrom Feb 2, 2022
Merged
Ignore queries and hashes in file names when preserving modules#4374lukastaegert merged 2 commits intomasterfrom
lukastaegert merged 2 commits intomasterfrom
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#preserve-modules-queryor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4374 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 205 205
Lines 7311 7320 +9
Branches 2083 2083
=======================================
+ Hits 7218 7227 +9
Misses 34 34
Partials 59 59
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This is something that came up in the course of working on rollup/plugins#1038. Basically when
/main.jsto/main.js?entry-proxy, which in turn imports/main.js,then the actual entry point would have the file name
main.js_entry-proxy.jsinstead ofmain.js. This will be very confusing to the user. This issue does not turn up when not preserving modules as in that case, we ignore the "extension".js?entry-proxyand rewrite it as.jsinstead 😉I pondered how best to solve this and I found the easiest might be to just ignore queries and hashes when generating output file names for preserveModules. That means plugins still have the freedom to proxy to entirely different file names, but as long as they stick to a naming pattern
<original-id>?<plugin-suffix>, Rollup will generate "correct" file names.