chore: revert rollup commonjs plugin to v20#4308
Closed
dnalborczyk wants to merge 1 commit intorollup:masterfrom
Closed
chore: revert rollup commonjs plugin to v20#4308dnalborczyk wants to merge 1 commit intorollup:masterfrom
dnalborczyk wants to merge 1 commit intorollup:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4308 +/- ##
==========================================
- Coverage 98.45% 98.42% -0.03%
==========================================
Files 205 205
Lines 7311 7313 +2
Branches 2082 2083 +1
==========================================
Hits 7198 7198
- Misses 55 56 +1
- Partials 58 59 +1
Continue to review full report at Codecov.
|
Contributor
|
A mocha test should be added to confirm the existence of the functions in #4300 (comment). |
9 tasks
Contributor
|
Although this PR would avoid random watch test failures on Mac, it appears that the problem is more nuanced than I first thought - see #4300 (comment). |
Contributor
Author
|
superseded by: #4312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
temporary "fixes": #4300 (comment)
/cc @kzc