Make sure this.load waits for modules that are already loading#4296
Merged
lukastaegert merged 2 commits intomasterfrom Dec 11, 2021
Merged
Make sure this.load waits for modules that are already loading#4296lukastaegert merged 2 commits intomasterfrom
lukastaegert merged 2 commits intomasterfrom
Conversation
Closed
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4294-preloaded-codeor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4296 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 205 205
Lines 7311 7311
Branches 2082 2082
=======================================
Hits 7198 7198
Misses 55 55
Partials 58 58
Continue to review full report at Codecov.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #4294
Description
this.loadis meant to wait until thecodeof a module is available. This was not the case if a module was already loading for some other reason.