Skip to content

chore: bump deps#4293

Merged
lukastaegert merged 8 commits intorollup:masterfrom
dnalborczyk:bump-deps
Dec 9, 2021
Merged

chore: bump deps#4293
lukastaegert merged 8 commits intorollup:masterfrom
dnalborczyk:bump-deps

Conversation

@dnalborczyk
Copy link
Copy Markdown
Contributor

@dnalborczyk dnalborczyk commented Dec 8, 2021 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

acorn v8.6.0 added support for ergonomic brand checks for private fields #4292

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 8, 2021 •
edited
Loading

Codecov Report

Merging #4293 (6af0b9a) into master (7c9b89f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4293      +/-   ##
==========================================
+ Coverage   98.40%   98.42%   +0.02%     
==========================================
  Files         204      205       +1     
  Lines        7319     7317       -2     
  Branches     2084     2083       -1     
==========================================
  Hits         7202     7202              
+ Misses         58       57       -1     
+ Partials       59       58       -1
Impacted Files Coverage Δ
cli/logging.ts 83.33% <ø> (-1.67%) ⬇️
cli/run/batchWarnings.ts 99.19% <ø> (ø)
cli/run/build.ts 91.89% <ø> (ø)
cli/run/loadConfigFile.ts 96.15% <ø> (ø)
cli/run/timings.ts 0.00% <ø> (ø)
cli/run/waitForInput.ts 100.00% <ø> (ø)
cli/run/watch-cli.ts 91.89% <ø> (ø)
src/utils/colors.ts 100.00% <100.00%> (ø)
src/watch/fsevents-importer.ts 75.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9b89f...6af0b9a. Read the comment docs.

@dnalborczyk dnalborczyk force-pushed the bump-deps branch 2 times, most recently from b0b291d to d287299 Compare December 8, 2021 01:46
@dnalborczyk dnalborczyk force-pushed the bump-deps branch 2 times, most recently from da44227 to 16803f0 Compare December 8, 2021 01:51
lukastaegert
lukastaegert approved these changes Dec 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, only thing I wonder about is how you managed to updated mocha without the Node 10 tests breaking. But I guess if it works, awesome, as these are just dev dependencies, no harm done. Reminds me to put some steam behind that Rollup 3 release soon...

@lukastaegert lukastaegert merged commit dbcf24a into rollup:master Dec 9, 2021
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 9, 2021
Closed
@dnalborczyk dnalborczyk deleted the bump-deps branch December 9, 2021 22:45
@dnalborczyk
Copy link
Copy Markdown
Contributor Author

dnalborczyk commented Dec 10, 2021

Thanks! Looks good, only thing I wonder about is how you managed to updated mocha without the Node 10 tests breaking.

I think a lot of times it just means that the "support" is dropped by excluding that version from the ci. as long as not any non-supported js syntax, js api or node.js api is being used it should keep working. once it does use unsupported features, we can pin that specific version.

Reminds me to put some steam behind that Rollup 3 release soon...

have you started in some branch already?

@sync-by-unito sync-by-unito bot mentioned this pull request Dec 13, 2021
Closed
@dnalborczyk dnalborczyk mentioned this pull request Dec 13, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dnalborczyk @lukastaegert