Codecov Report

Merging #4219 (ec86116) into master (181f379) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4219   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         202      202           
  Lines        7259     7260    +1     
  Branches     2119     2119           
=======================================
+ Hits         7141     7142    +1     
  Misses         58       58           
  Partials       60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 181f379...ec86116. Read the comment docs.

wouldn't it be better to dogfood from the source directly?

Sounds like a plan, though this could have quite some impact on build times which again would have some impact on test execution times, but maybe there are solutions. At least on CI, I would hope that we run tests against the compiled version of Rollup just like an end user would do.
Locally, it might be an option not to do that. One issue is the markdown import for the CLI options file.

I guess if one were to make a PR for this, we can definitely talk about it. Depending on how it is done, one might also use TypeScripts watch mode (rather than ts-node) for local test executions, which might give a nice speed boost.

There is also a long-standing issue about this.

One reason I never updated the TypeScript plugin is because the old one actually allowed you to write invalid code to try out stuff 😜 I guess that is what previously "fixed" the fsevents types. But I agree that we should update, especially since performance seems to be pretty neat by now.

ah, I see, that would explain it 😄 . also just found this: https://github.com/rollup/plugins/tree/master/packages/typescript#faster-compiling that seems to bit unfortunate, I like to turn off type checking once in a while as well, as you can prototype faster. e.g. with the ts-node --transpile-only flag.

Do you know if there is a way to get rid of the CreatingProgramWith:: log when building? It seems to be something done by the TypeScript compiler.

I looked into the typescript code and that log is emitted with the diagnostics flag, which is also deprecated. I removed it for now. not sure what a good replacement for that flag would be, as I have never used it. 🤔 https://www.typescriptlang.org/tsconfig#diagnostics

I looked into the typescript code and that log is emitted with the diagnostics flag

Ah, good digging, thanks a lot. So it was our own fault, but we never noticed because before, the flag was ignored. Now it looks nice like it should.

BTW if you notice the license file having a lot of changes after you install something, the reason is that for some reason, the package files in node_modules look slightly differently depending on whether you last used npm install or npm ci. To fix it, just run npm ci after npm install (which is what I pushed to your branch, I hope you do not mind).

BTW if you notice the license file having a lot of changes after you install something, the reason is that for some reason, the package files in node_modules look slightly differently depending on whether you last used npm install or npm ci. To fix it, just run npm ci after npm install (which is what I pushed to your branch, I hope you do not mind).

ah, thank you, good to know! that sounds like a bug with npm. 🤔