Skip to content

Use issue forms#4152

Merged
lukastaegert merged 7 commits into
rollup:masterfrom
tjenkinson:issue-form
Jun 27, 2021
Merged

Use issue forms#4152
lukastaegert merged 7 commits into
rollup:masterfrom
tjenkinson:issue-form

Conversation

@tjenkinson

@tjenkinson tjenkinson commented Jun 26, 2021

Copy link
Copy Markdown
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

Description

Update the issue templates to use issue forms instead. This feature was just released to beta.

No need for html comments anymore :)

Not sure if you want the auto labels or if they're the ones you want so feel free to edit them.

I created a test repo here if you want to see what it looks like.

@github-actions

Copy link
Copy Markdown

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install tjenkinson/rollup#issue-form

or load it into the REPL:
https://rollupjs.org/repl/?pr=4152

@codecov

codecov Bot commented Jun 26, 2021

Copy link
Copy Markdown

Codecov Report

Merging #4152 (a0f4f23) into master (feafc47) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4152   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         201      201           
  Lines        7118     7118           
  Branches     2084     2084           
=======================================
  Hits         6996     6996           
  Misses         58       58           
  Partials       64       64           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feafc47...a0f4f23. Read the comment docs.

@lukastaegert lukastaegert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool, thanks a lot for making us aware and setting this up! I had only minor comments about the labels.json, otherwise this is really useful. Especially the required fields handling, and the automatically added labels also go a long way. I also like the "triage" label meaning nobody had a look at this :)

Comment thread .github/ISSUE_TEMPLATE/bug.yaml Outdated
Comment thread .github/labels.json
@@ -39,6 +39,8 @@
{ "name": "t⁴ ⋅ regression", "color": "#0052cc" },

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can actually remove the first two about incomplete/removed templates now!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People can still edit manually or use a blank template so they still might be useful?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you are right

@lukastaegert lukastaegert merged commit 788266f into rollup:master Jun 27, 2021
@shellscape

Copy link
Copy Markdown
Contributor

Wow this looks fantastic. Definitely will implement in the plugins repo this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants