Skip to content

feat: Export defineConfig defines the auxiliary function of the configuration#4127

Merged
lukastaegert merged 3 commits into
rollup:masterfrom
rxliuli:feat_defineConfig
Jun 6, 2021
Merged

feat: Export defineConfig defines the auxiliary function of the configuration#4127
lukastaegert merged 3 commits into
rollup:masterfrom
rxliuli:feat_defineConfig

Conversation

@rxliuli

@rxliuli rxliuli commented Jun 6, 2021

Copy link
Copy Markdown
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers: #4125

Description

@rxliuli

rxliuli commented Jun 6, 2021

Copy link
Copy Markdown
Contributor Author

@lukastaegert I added some documentation at the end

@github-actions

github-actions Bot commented Jun 6, 2021 •
edited
Loading

Copy link
Copy Markdown

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rxliuli/rollup#feat_defineConfig

or load it into the REPL:
https://rollupjs.org/repl/?pr=4127

@rxliuli rxliuli changed the title Feat define config feat: Export defineConfig defines the auxiliary function of the configuration Jun 6, 2021
@rxliuli rxliuli mentioned this pull request Jun 6, 2021
Closed
9 tasks
@codecov

codecov Bot commented Jun 6, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4127 (555cac3) into master (9f69fe3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4127   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         201      201           
  Lines        7077     7077           
  Branches     2071     2071           
=======================================
  Hits         6944     6944           
  Misses         64       64           
  Partials       69       69
Impacted Files Coverage Δ
src/rollup/rollup.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f69fe3...555cac3. Read the comment docs.

lukastaegert
lukastaegert reviewed Jun 6, 2021
View reviewed changes
Comment thread docs/01-command-line-reference.md Outdated
}
```

Config Intellisense

@lukastaegert lukastaegert Jun 6, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should make this a #### sub-heading so that it looks right on the web site

@lukastaegert lukastaegert Jun 6, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks great!

@rxliuli rxliuli Jun 6, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added: 555cac3

lukastaegert
lukastaegert approved these changes Jun 6, 2021
View reviewed changes

@lukastaegert lukastaegert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@rxliuli

rxliuli commented Jun 6, 2021

Copy link
Copy Markdown
Contributor Author

I would like to ask, if yes, is it possible to support ts type configuration files? If I create a new PR to support this feature, will it be merged?

@lukastaegert

lukastaegert commented Jun 6, 2021

Copy link
Copy Markdown
Member

There is already a PR for this which got stalled: #3835
However, discussions were already pretty advanced, maybe we can move that one forward? The general idea would be to allow using plugins to transpile the config file, just the specifics were not finalized.

@lukastaegert lukastaegert merged commit d985955 into rollup:master Jun 6, 2021
@tasshi-me tasshi-me mentioned this pull request Jun 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rxliuli @lukastaegert