Actually set the prototype when using a __proto__ property#4112
Merged
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4094-proto-accessorsor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4112 +/- ##
==========================================
+ Coverage 98.08% 98.10% +0.01%
==========================================
Files 201 201
Lines 7056 7059 +3
Branches 2061 2063 +2
==========================================
+ Hits 6921 6925 +4
Misses 64 64
+ Partials 71 70 -1
Continue to review full report at Codecov.
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #4094
Description
This replaces the clunky logic that was previously used for
__proto__object literal properties by actually setting the prototype when such a property is encountered. This will immediately add support for accessors on the new prototype. There is special handling for the case where the property is the literalnull. Only in this case, a prototype-free object will be created: REPLIn all other cases, the expression given is used as prototype. As far as I can see, this should only lead to unnecessary but harmless deoptimizations in cases when e.g.
undefinedis provided (as then all prototype property accesses should just be treated as side effects).