Merged
Conversation
Collaborator
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3813 +/- ##
==========================================
- Coverage 97.05% 97.05% -0.01%
==========================================
Files 185 185
Lines 6482 6477 -5
Branches 1877 1873 -4
==========================================
- Hits 6291 6286 -5
Misses 101 101
Partials 90 90
Continue to review full report at Codecov.
|
9 tasks
347c0e3 to
0ac41a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This adds a new hook
moduleParsedthat is called for each module after thetransformhook. This is needed to be notified once a cached module is available and will be useful to finally fix the caching for the commonjs plugin. Mainly, this hook will be used to resolve if a module is commonjs or ES both for cached and other modules.moduleParsedType:
(moduleInfo: ModuleInfo) => voidKind:
async, parallelPrevious Hook:
transformwhere the currently handled file was transformed.NextHook:
resolveIdandresolveDynamicImportto resolve all discovered static and dynamic imports in parallel if present, otherwisebuildEnd.This hook is called each time a module has been fully parsed by Rollup. See
this.getModuleInfofor what information is passed to this hook.In contrast to the
transformhook, this hook is never cached and can be used to get information about both cached and other modules, including the final shape of themetaproperty, thecodeand theast.Note that information about imported modules is not yet available in this hook, and information about importing modules may be incomplete as additional importers could be discovered later. If you need this information, use the
buildEndhook.