-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Description
Expected Behavior / Situation
The expected behaviour is the one before #4983 - not to close stdout with process.stdout.end(). Subsequent writes to stdout (through node) will continue to be successful.
Actual Behavior / Situation
With #4983 / Rollup v3.21.6, stdout is closed. Subsequent writes to stdout will fail.
Our specific case:
- We use the Firebase action-hosting-deploy GitHub action to deploy to firebase.
- We use a predeploy hook to invoke rollup as part of the deployment.
- With v3.21.6 this started to fail because stdout (within node) is closed after the rollup commands but the GitHub action looks for the success message from deployment in that log (see https://github.com/FirebaseExtended/action-hosting-deploy/blob/4d0d0023f1d92b9b7d16dda64b3d7abd2c98974b/src/deploy.ts#L150).
Modification Proposal
Roll back the change in #4983 (and solve it differently, without affecting the node process beyond Rollup).
Reactions are currently unavailable