build(rust): mimalloc-safe/no_opt_arch on aarch64 (#6072)

cyyynthia · web-flow · commit a44003e93ea1 · 2025-08-21T04:49:25.000Z
* build(rust): mimalloc-safe/no_opt_arch on aarch64 initially introduced by #6055 for linux, this did not include android devices as it is considerd its own operating system with linux being the "vendor"; triplets are quite inconsistent and confusing at times! this change conservatively disables arch-specific optimizations for all aarch64 targets, to ensure broad compatibility. closes #6047 * build(rust): exclude Apple from arch-specific opt-out
diff --git a/rust/bindings_napi/Cargo.toml b/rust/bindings_napi/Cargo.toml
@@ -18,11 +18,28 @@ xxhash = { path = "../xxhash" }
 [target.'cfg(not(any(target_os = "linux", target_os = "freebsd")))'.dependencies]
 mimalloc-safe = { version = "0.1.54" }
 
-[target.'cfg(any(all(target_os = "linux", not(target_arch = "aarch64"), not(target_arch = "loongarch64"), not(all(target_arch = "riscv64", target_env = "musl"))), all(target_os = "freebsd", not(target_arch = "aarch64"))))'.dependencies]
+# Readable version of the target specifier
+# cfg(
+# 	any(
+# 		all(
+# 			target_os = "linux",
+# 			not(target_arch = "loongarch64"),
+# 			not(all(target_arch = "riscv64", target_env = "musl"))
+# 		),
+# 		all(
+# 			target_os = "freebsd",
+# 			not(target_arch = "aarch64")
+# 		)
+# 	)
+# )
+[target.'cfg(any(all(target_os = "linux", not(target_arch = "loongarch64"), not(all(target_arch = "riscv64", target_env = "musl"))), all(target_os = "freebsd", not(target_arch = "aarch64"))))'.dependencies]
 mimalloc-safe = { version = "0.1.54", features = ["local_dynamic_tls"] }
 
-[target.'cfg(all(target_os = "linux", target_arch = "aarch64"))'.dependencies]
-mimalloc-safe = { version = "0.1.54", features = ["local_dynamic_tls", "no_opt_arch"] }
+# Disable architecture specific optimizations on aarch64 platforms
+# Mimalloc assumes `armv8.1-a` is supported, which is not always the case
+# Ref: https://github.com/rollup/rollup/issues/6047
+[target.'cfg(all(target_arch = "aarch64", not(target_vendor = "apple")))'.dependencies]
+mimalloc-safe = { version = "0.1.54", features = ["no_opt_arch"] }
 
 [build-dependencies]
 napi-build = "2.2.3"
