fix(node-resolve): fix error when custom resolve option missing#1029
Closed
tjenkinson wants to merge 1 commit intomasterfrom
Closed
fix(node-resolve): fix error when custom resolve option missing#1029tjenkinson wants to merge 1 commit intomasterfrom
custom resolve option missing#1029tjenkinson wants to merge 1 commit intomasterfrom
Conversation
9 tasks
Collaborator
|
Unless there's a 2.x version of rollup which also lacks that, we don't have to account for this scenario. see: #1023 (comment) |
Member
Author
|
Ah yep good spot. Not sure when |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
node-resolveThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: fixes #1023
Description
I think older rollup versions will not provide
custom, so we should handle it beingundefined, as we did before #1016There is not test for this, but to test it we either need to fake a call or somehow being in an older rollup version for the test.