feat(node-resolve): export defaults (#301)

MichaelDeBoey · web-flow · commit ee5be6a7d870 · 2020-04-22T11:56:02.000-04:00
BREAKING CHANGE:

The plugin function is no longer the default export. Moving forward, there are two named exports:

```js
{ DEFAULTS, nodeResolve }
```

* feat(node-resolve): Export defaults

* Wrap module

* Don't export DEFAULT_OPTIONS directly

* Create cjs-wrapper

* Named export

* Freeze defaults

* Deep freeze defaults

* Deep merge defaults
diff --git a/packages/node-resolve/package.json b/packages/node-resolve/package.json
@@ -51,6 +51,8 @@
     "@rollup/pluginutils": "^3.0.8",
     "@types/resolve": "0.0.8",
     "builtin-modules": "^3.1.0",
+    "deep-freeze": "^0.0.1",
+    "deepmerge": "^4.2.2",
     "is-module": "^1.0.0",
     "resolve": "^1.14.2"
   },
diff --git a/packages/node-resolve/src/index.js b/packages/node-resolve/src/index.js
@@ -2,6 +2,8 @@
 import { dirname, normalize, resolve, sep } from 'path';
 
 import builtinList from 'builtin-modules';
+import deepFreeze from 'deep-freeze';
+import deepMerge from 'deepmerge';
 import isModule from 'is-module';
 
 import { isDirCached, isFileCached, readCachedFile } from './cache';
@@ -25,8 +27,9 @@ const defaults = {
   extensions: ['.mjs', '.js', '.json', '.node'],
   resolveOnly: []
 };
+export const DEFAULTS = deepFreeze(deepMerge({}, defaults));
 
-export default function nodeResolve(opts = {}) {
+export const nodeResolve = (opts = {}) => {
   const options = Object.assign({}, defaults, opts);
   const { customResolveOptions, extensions, jail } = options;
   const warnings = [];
@@ -250,4 +253,4 @@ export default function nodeResolve(opts = {}) {
       return idToPackageInfo.get(id);
     }
   };
-}
+};
diff --git a/packages/node-resolve/test/browser.js b/packages/node-resolve/test/browser.js
@@ -6,7 +6,7 @@ const commonjs = require('rollup-plugin-commonjs');
 
 const { testBundle } = require('../../../util/test');
 
-const nodeResolve = require('..');
+const { nodeResolve } = require('..');
 
 process.chdir(join(__dirname, 'fixtures'));
 
diff --git a/packages/node-resolve/test/dedupe-custom.js b/packages/node-resolve/test/dedupe-custom.js
@@ -5,7 +5,7 @@ const { rollup } = require('rollup');
 
 const { testBundle } = require('../../../util/test');
 
-const nodeResolve = require('..');
+const { nodeResolve } = require('..');
 
 process.chdir(join(__dirname, 'fixtures', 'custom-resolve-options'));
 
diff --git a/packages/node-resolve/test/dedupe.js b/packages/node-resolve/test/dedupe.js
@@ -5,7 +5,7 @@ const { rollup } = require('rollup');
 
 const { testBundle } = require('../../../util/test');
 
-const nodeResolve = require('..');
+const { nodeResolve } = require('..');
 
 process.chdir(join(__dirname, 'fixtures'));
 
diff --git a/packages/node-resolve/test/get-package-info.js b/packages/node-resolve/test/get-package-info.js
@@ -5,7 +5,7 @@ const path = require('path');
 const test = require('ava');
 const { rollup } = require('rollup');
 
-const nodeResolve = require('..');
+const { nodeResolve } = require('..');
 
 process.chdir(path.join(__dirname, 'fixtures'));
 
diff --git a/packages/node-resolve/test/jail.js b/packages/node-resolve/test/jail.js
@@ -5,7 +5,7 @@ const { rollup } = require('rollup');
 
 const { getImports } = require('../../../util/test');
 
-const nodeResolve = require('..');
+const { nodeResolve } = require('..');
 
 process.chdir(join(__dirname, 'fixtures'));
 
diff --git a/packages/node-resolve/test/only.js b/packages/node-resolve/test/only.js
@@ -5,7 +5,7 @@ const { rollup } = require('rollup');
 
 const { getImports } = require('../../../util/test');
 
-const nodeResolve = require('..');
+const { nodeResolve } = require('..');
 
 process.chdir(join(__dirname, 'fixtures'));
 
diff --git a/packages/node-resolve/test/order.js b/packages/node-resolve/test/order.js
@@ -5,7 +5,7 @@ const { rollup } = require('rollup');
 
 const { testBundle } = require('../../../util/test');
 
-const nodeResolve = require('..');
+const { nodeResolve } = require('..');
 
 process.chdir(join(__dirname, 'fixtures'));
 
diff --git a/packages/node-resolve/test/prefer-builtins.js b/packages/node-resolve/test/prefer-builtins.js
@@ -5,7 +5,7 @@ const { rollup } = require('rollup');
 
 const { getImports, testBundle } = require('../../../util/test');
 
-const nodeResolve = require('..');
+const { nodeResolve } = require('..');
 
 process.chdir(join(__dirname, 'fixtures'));
 
diff --git a/packages/node-resolve/test/root-dir.js b/packages/node-resolve/test/root-dir.js
@@ -5,7 +5,7 @@ const { rollup } = require('rollup');
 
 const { testBundle } = require('../../../util/test');
 
-const nodeResolve = require('..');
+const { nodeResolve } = require('..');
 
 process.chdir(join(__dirname, 'fixtures', 'monorepo-dedupe', 'packages', 'package-a'));
 
diff --git a/packages/node-resolve/test/symlinks.js b/packages/node-resolve/test/symlinks.js
@@ -6,7 +6,7 @@ const { rollup } = require('rollup');
 
 const { testBundle } = require('../../../util/test');
 
-const nodeResolve = require('..');
+const { nodeResolve } = require('..');
 
 process.chdir(join(__dirname, 'fixtures'));
 
diff --git a/packages/node-resolve/test/test.js b/packages/node-resolve/test/test.js
@@ -7,7 +7,7 @@ const commonjs = require('rollup-plugin-commonjs');
 
 const { getCode, getImports, testBundle } = require('../../../util/test');
 
-const nodeResolve = require('..');
+const { nodeResolve } = require('..');
 
 process.chdir(join(__dirname, 'fixtures'));
 
diff --git a/packages/node-resolve/test/types.ts b/packages/node-resolve/test/types.ts
@@ -1,5 +1,5 @@
 // @ts-check
-import resolve from '..';
+import { nodeResolve } from '..';
 
 /** @type {import("rollup").RollupOptions} */
 const config = {
@@ -10,7 +10,7 @@ const config = {
     name: 'MyModule'
   },
   plugins: [
-    resolve({
+    nodeResolve({
       browser: true,
       customResolveOptions: {
         moduleDirectory: 'js_modules'
diff --git a/packages/node-resolve/types/index.d.ts b/packages/node-resolve/types/index.d.ts
@@ -1,6 +1,13 @@
 import { Plugin } from 'rollup';
 import { AsyncOpts } from 'resolve';
 
+export const DEFAULTS: {
+  customResolveOptions: {};
+  dedupe: [];
+  extensions: ['.mjs', '.js', '.json', '.node'];
+  resolveOnly: [];
+};
+
 export interface Options {
   /**
    * If `true`, instructs the plugin to use the `"browser"` property in `package.json`
@@ -81,4 +88,4 @@ export interface Options {
 /**
  * Locate modules using the Node resolution algorithm, for using third party modules in node_modules
  */
-export default function nodeResolve(options?: Options): Plugin;
+export const nodeResolve: (options?: Options) => Plugin;
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
