feat(css): support node_modules packages in Sass#812
Merged
Conversation
Extract shared ResolverFactory logic into resolve.ts module with getCssResolver() for CSS and getSassResolver() for Sass. Update tryResolveScss() to fall back to node_modules resolution via oxc resolver when local file resolution fails, matching Vite's behavior. Fixes #811 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract shared ResolverFactory logic into
resolve.tsmodule and add node_modules package resolution support for Sass@use/@importstatements. The Sass resolver now falls back to oxc's module resolver (matching Vite's approach) when local file resolution fails, enabling packages like@vuepress/helperto be imported directly without manualNodePackageImporterconfiguration.Fixes #811
Test Coverage
Added test case
sass resolves node_modules packagesthat verifies@use '@my-lib/styles/vars'correctly resolves scoped packages from node_modules using the oxc resolver with propersassandstylecondition/mainFields support.🤖 Generated with Claude Code