Conversation
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates tsdown’s CSS handling so that module IDs with URL queries (e.g. foo.css?raw) are ignored by the built-in/advanced CSS plugins, allowing other plugins (like unplugin-raw) to process them.
Changes:
- Updated CSS/preprocessor detection regexes to only match file extensions at end-of-string (no
?query). - Added a Vitest case + snapshot covering
import './foo.css?raw'working viaunplugin-raw. - Added
unplugin-rawas a dev dependency (workspace catalog + lockfile updates).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/css.test.ts | Adds a regression test ensuring .css?raw can be handled by unplugin-raw. |
| tests/snapshots/css/handle-css-raw-with-unplugin-raw.snap.md | Snapshot for the new .css?raw test output. |
| src/features/css/preprocessors.ts | Stops treating *.css?query / *.scss?query etc as CSS/preprocessor inputs. |
| src/features/css/plugin.ts | Makes the built-in CSS plugin ignore .css?query by tightening RE_CSS. |
| packages/css/src/preprocessors.ts | Mirrors the CSS/preprocessor detection change for the @tsdown/css package. |
| package.json | Adds unplugin-raw to devDependencies via the workspace catalog. |
| pnpm-workspace.yaml | Adds unplugin-raw to the dev catalog. |
| pnpm-lock.yaml | Locks unplugin-raw resolution. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sxzz
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current, you cannot use
import cssText from './foo.css?raw'with unplugin-raw because@tsdown/csshandles this ID.This PR makes tsdown
@tsdown/cssignore any CSS files with URL queries (e.g.?raw).Linked Issues
See also #804
Additional context