feat(attw): add ignoreRules option to filter specified rule#665
Merged
sxzz merged 5 commits intorolldown:mainfrom Dec 22, 2025
Merged
feat(attw): add ignoreRules option to filter specified rule#665sxzz merged 5 commits intorolldown:mainfrom
ignoreRules option to filter specified rule#665sxzz merged 5 commits intorolldown:mainfrom
Conversation
✅ Deploy Preview for tsdown ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an ignoreRules configuration option to the ATTW (Are The Types Wrong) feature, allowing users to selectively filter out specific problem types when checking package type correctness. The implementation maps ProblemKind enum values to their corresponding CLI flag names and validates user input against allowed values.
- Added
problemFlagsconstant mapping ProblemKind types to string identifiers - Extended
AttwOptionsinterface withignoreRulesoption accepting an array of problem flag strings - Implemented validation and filtering logic to exclude specified problem types from the check results
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
sxzz
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to https://github.com/arethetypeswrong/arethetypeswrong.github.io/blob/main/packages/cli/README.md#ignore-rules
Linked Issues
Additional context