Skip to content

fix(workspace): path compatibility issue under windows#376

Merged
sxzz merged 2 commits intorolldown:mainfrom
RSS1102:rss1102/fix/workspace/windows-path
Jul 15, 2025
Merged

fix(workspace): path compatibility issue under windows#376
sxzz merged 2 commits intorolldown:mainfrom
RSS1102:rss1102/fix/workspace/windows-path

Conversation

@RSS1102
Copy link
Contributor

@RSS1102 RSS1102 commented Jul 15, 2025

Description

In Windows, the package index package will have a path error, I use normalizepath to normalize the path to solve this compatibility error.

559f8f3801df5308601a4a4eeb3a0aea

Linked Issues

Additional context

@netlify
Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for tsdown ready!

Name Link
🔨 Latest commit 25ecb90
🔍 Latest deploy log https://app.netlify.com/projects/tsdown/deploys/68766b8c17ac670008621a9d
😎 Deploy Preview https://deploy-preview-376--tsdown.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sxzz
Copy link
Member

sxzz commented Jul 15, 2025

Use slash from src/utils/general.ts instead.

@RSS1102

This comment was marked as resolved.

@RSS1102
Copy link
Contributor Author

RSS1102 commented Jul 15, 2025

改用slashfrom src/utils/general.ts

ok

@RSS1102
Copy link
Contributor Author

RSS1102 commented Jul 15, 2025

It seems that there are many places in the project where path.resolve is used. Will they all have Windows compatibility error?

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 15, 2025

Open in StackBlitz

npm i https://pkg.pr.new/tsdown@376

commit: 25ecb90

@sxzz
Copy link
Member

sxzz commented Jul 15, 2025

Some usages are intended solely for display or file system operations, not for searching or matching.

@sxzz sxzz merged commit 375d997 into rolldown:main Jul 15, 2025
13 checks passed
@RSS1102 RSS1102 deleted the rss1102/fix/workspace/windows-path branch July 15, 2025 15:15
@RSS1102
Copy link
Contributor Author

RSS1102 commented Jul 15, 2025

Ok, let me try it out with pkg.pr.new to my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants