Merged
Conversation
✅ Deploy Preview for tsdown ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
Contributor
Author
|
@sxzz I want to hear your opinion and continue the task based on it (Please share your thoughts!) |
81add3a to
434d6a4
Compare
sxzz
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
Hello. I'm an enthusiast of tsup and have great interest in the tsdown project.
This PR is merely a suggestion and I submitted it with the intention of having a discussion with you.
If this PR doesn't align with the direction of tsdown, please feel free to close it.
tsdown is a project inspired by tsup, and in fact, many of its configuration structures and core philosophies are designed similarly.
For that reason, tsup users who switch to tsdown inevitably expect a similar developer experience (DX).
I believe the banner and footer features fall within that context. These are widely used in various bundlers such as Rollup, esbuild, and webpack, and have been supported in tsup as well.
However, since tsdown currently uses rolldown internally, although the functionality itself is easy to implement, the configuration method has changed.
As a result, existing tsup users face an unnecessary entry barrier by having to look up documentation again or modify their existing configurations.
I believe this isn't just an interface difference, but a factor that causes friction during migration.
To become a project that tsup users can naturally transition to, I think it's important to maintain as much functional parity and consistency in configuration interface as possible. (Just my opinion.)
This PR, as part of that, proposes adopting the same banner/footer configuration style as tsup.
Of course, due to rolldown's structure, the future direction may change.
If so, I think we could proceed by separating it through a breaking change via versioning later on.
However, at this stage, encouraging user adoption with low friction and then shaping the direction seems like a more strategic approach.
The fact that users can transition with a similar API and minimal configuration changes could offer great convenience.
Linked Issues
closed: #288