[WIP] [WIP] Address feedback on fixing Vite test CI failure with ESM init call#9753
Closed
IWANABETHATGUY with Copilot wants to merge 2 commits into
Closed
[WIP] [WIP] Address feedback on fixing Vite test CI failure with ESM init call#9753IWANABETHATGUY with Copilot wants to merge 2 commits into
IWANABETHATGUY with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: IWANABETHATGUY <17974631+IWANABETHATGUY@users.noreply.github.com>
Member
|
@sapphi-red just try to fix the vite CI failure, I don't have enough knowledge about the setup, feel free to close this pr. |
Member
|
@copilot Use a proper pr title that satisfies the CI requirement. |
Member
|
after review the code I think it is just a workaround, closed. |
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the feedback on #9717. I've created this new PR, which merges into #9717, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.
Original PR: #9717
Triggering review: #9717 (comment)