This check will incorrectly return false for side-effect imports that don't use the from keyword:

import './side-effect-module'

Such imports start with "import" but don't contain "from". This could cause modules with side-effect imports to be misclassified, potentially leading to incorrect pure re-export detection. The logic should handle all valid import statement formats including side-effect imports.

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.

String pattern matching is too simplistic and will cause false positives. The check if export_str.contains("import") will incorrectly reject valid reexport statements that contain the substring "import" in identifiers (e.g., export { importantData } from './data'). This will cause modules to be incorrectly classified as non-pure-reexports, preventing proper chunk optimization.

// This check is too broad - it rejects any statement containing "import"
// even if "import" appears in a variable name like "importantData"
if export_str.contains("import") {
  return false;
}

Recommendation: Use proper AST-based checks instead of string matching, or use more precise regex patterns that match only the import keyword.

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.