Skip to content

Add comprehensive test coverage for dynamic entry facade chunk optimization#7614

Closed
Copilot wants to merge 6 commits intomainfrom
copilot/sub-pr-7486
Closed

Add comprehensive test coverage for dynamic entry facade chunk optimization#7614
Copilot wants to merge 6 commits intomainfrom
copilot/sub-pr-7486

Conversation

Copy link
Contributor

Copilot AI commented Dec 21, 2025

  • Review existing test case and implementation
  • Create test case 1: Multiple dynamic imports to the same module with different imported properties
  • Create test case 2: Dynamic entry chunks that have some modules (not completely empty)
  • Create test case 3: Dynamic entry chunks merged into non-AdvancedChunks common chunks (removed - redundant)
  • Create test case 4: Interaction with other chunk optimization strategies
  • Create test case 5: Cases where the runtime module needs to be assigned to different chunks
  • Validate all tests pass
  • Request code review
  • Address reviewer feedback
  • Rebase onto updated parent branch

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

renovate bot and others added 4 commits December 21, 2025 23:37
This PR contains the following updates:

| Package | Change |
[Age](https://docs.renovatebot.com/merge-confidence/) |
[Adoption](https://docs.renovatebot.com/merge-confidence/) |
[Passing](https://docs.renovatebot.com/merge-confidence/) |
[Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|---|---|
|
[rolldown-plugin-dts](https://redirect.github.com/sxzz/rolldown-plugin-dts)
| [`^0.18.0` ->
`^0.19.0`](https://renovatebot.com/diffs/npm/rolldown-plugin-dts/0.18.4/0.19.1)
|
![age](https://developer.mend.io/api/mc/badges/age/npm/rolldown-plugin-dts/0.19.1?slim=true)
|
![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/rolldown-plugin-dts/0.19.1?slim=true)
|
![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/rolldown-plugin-dts/0.18.4/0.19.1?slim=true)
|
![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/rolldown-plugin-dts/0.18.4/0.19.1?slim=true)
|

---

<details>
<summary>sxzz/rolldown-plugin-dts (rolldown-plugin-dts)</summary>

[`v0.19.1`](https://redirect.github.com/sxzz/rolldown-plugin-dts/releases/tag/v0.19.1)

[Compare
Source](https://redirect.github.com/sxzz/rolldown-plugin-dts/compare/v0.19.0...v0.19.1)

- Remove unused dep  -  by
[@&#8203;sxzz](https://redirect.github.com/sxzz)
[<samp>(430a0)</samp>](https://redirect.github.com/sxzz/rolldown-plugin-dts/commit/430a0b6)

GitHub](https://redirect.github.com/sxzz/rolldown-plugin-dts/compare/v0.19.0...v0.19.1)

[`v0.19.0`](https://redirect.github.com/sxzz/rolldown-plugin-dts/releases/tag/v0.19.0)

[Compare
Source](https://redirect.github.com/sxzz/rolldown-plugin-dts/compare/v0.18.4...v0.19.0)

- Drop `banner` / `footer`  -  by
[@&#8203;sxzz](https://redirect.github.com/sxzz)
[<samp>(56403)</samp>](https://redirect.github.com/sxzz/rolldown-plugin-dts/commit/5640374)

GitHub](https://redirect.github.com/sxzz/rolldown-plugin-dts/compare/v0.18.4...v0.19.0)

</details>

---

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/rolldown/rolldown).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi41OS4wIiwidXBkYXRlZEluVmVyIjoiNDIuNTkuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix: `postBanner` content should be placed after shebang (#7583)

The content generated by `postBanner` should be after the shebang;
otherwise, it will cause file errors.

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Yunfei He <i.heyunfei@gmail.com>

fix(types): better "go to definition" experience for interface `OutputPlugin` (#7610)

Signed-off-by: Yunfei He <i.heyunfei@gmail.com>
Co-authored-by: Yunfei He <i.heyunfei@gmail.com>

fix(types): better "go to definition" experience for interface `OutputPlugin` (#7610)

Signed-off-by: Yunfei He <i.heyunfei@gmail.com>
Co-authored-by: Yunfei He <i.heyunfei@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: IWANABETHATGUY <974153916@qq.com>
…zation

Added 5 new test cases covering:
- Multiple dynamic imports with different properties
- Non-empty chunks (should not be optimized)
- Non-advanced chunks (should not be optimized)
- Interaction with minChunkSize optimization
- Runtime module assignment to separate chunk

Co-authored-by: IWANABETHATGUY <17974631+IWANABETHATGUY@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on optimizing dynamic entry facade chunks merging Add comprehensive test coverage for dynamic entry facade chunk optimization Dec 21, 2025
Copilot AI requested a review from IWANABETHATGUY December 21, 2025 16:16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove this test case since it is already covered by other tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the redundant test case. Commit: 035bac7

Co-authored-by: IWANABETHATGUY <17974631+IWANABETHATGUY@users.noreply.github.com>
@IWANABETHATGUY
Copy link
Member

IWANABETHATGUY commented Dec 21, 2025

@copilot Can you rebase the branch?

Copy link
Contributor Author

Copilot AI commented Dec 21, 2025

@copilot Can you rebase the branch?

I've successfully rebased the branch onto the updated parent branch origin/12-11-feat_5276 (commit f873b46). The rebased commits are:

  • e614d94 - Initial plan
  • 52ffc0d - Add comprehensive test coverage
  • c318bd7 - Remove redundant test case

All tests pass after the rebase. However, I'm unable to force-push the rebased commits due to tooling constraints. The branch is ready locally - could you please force-push it, or let me know if there's an alternative approach you'd prefer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants