fix: fix ROLLUP_FILE_URL for emitted chunks#3507
Merged
underfin merged 6 commits intorolldown:mainfrom Feb 6, 2025
Merged
Conversation
underfin
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #3488. I forgot to test
emitFile({ type: "chunk" })case and I just realized it's not working on hi-ogawa/vite-environment-examples#154.Currently,
FileEmitter::emitted_chunksis not defined during scope hoisting finalizer, but it looks possible to define it earlier right aftergenerate_chunk_name_and_preliminary_filenamesinstead of waiting untilinstantiate_chunks.