Skip to content

feat(string_wizard): add .hasChanged()#3379

Merged
Boshen merged 1 commit intomainfrom
01-18-feat_string_wizard_add_.haschanged_
Jan 18, 2025
Merged

feat(string_wizard): add .hasChanged()#3379
Boshen merged 1 commit intomainfrom
01-18-feat_string_wizard_add_.haschanged_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jan 18, 2025

Boshen
Boshen commented Jan 18, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(5bb588b)
  • pr: 01-18-feat_string_wizard_add_.haschanged_(b6e4f2c)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     71.4±1.29ms        ? ?/sec    1.06     75.5±2.66ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     93.7±2.38ms        ? ?/sec    1.01     94.2±1.40ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    106.3±2.01ms        ? ?/sec    1.01    106.9±2.78ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     81.4±0.87ms        ? ?/sec    1.00     80.9±1.63ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    122.8±1.55ms        ? ?/sec    1.00    122.9±1.96ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    201.5±4.21ms        ? ?/sec    1.01    202.7±4.64ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    234.5±1.97ms        ? ?/sec    1.01    236.8±5.35ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.02    135.4±2.01ms        ? ?/sec    1.00    132.5±1.43ms        ? ?/sec
bundle/bundle@threejs                                               1.03     42.0±0.93ms        ? ?/sec    1.00     40.9±2.21ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     94.1±0.97ms        ? ?/sec    1.01     95.3±2.46ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    107.3±3.16ms        ? ?/sec    1.03    110.2±1.06ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     50.6±0.72ms        ? ?/sec    1.02     51.7±0.82ms        ? ?/sec
bundle/bundle@threejs10x                                            1.01    435.8±7.03ms        ? ?/sec    1.00    433.1±6.50ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1072.4±13.33ms        ? ?/sec    1.01   1078.2±9.40ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1261.6±16.67ms        ? ?/sec    1.48  1866.2±1173.16ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01    504.1±7.49ms        ? ?/sec    1.00    499.2±5.49ms        ? ?/sec
remapping/remapping                                                 1.05     27.0±0.99ms        ? ?/sec    1.00     25.6±0.31ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     64.7±0.54ms        ? ?/sec    1.01     65.3±0.67ms        ? ?/sec
scan/scan@rome-ts                                                   1.02     95.3±0.91ms        ? ?/sec    1.00     93.4±0.82ms        ? ?/sec
scan/scan@threejs                                                   1.03     31.4±0.39ms        ? ?/sec    1.00     30.6±0.23ms        ? ?/sec
scan/scan@threejs10x                                                1.01    316.3±3.09ms        ? ?/sec    1.00    312.8±3.23ms        ? ?/sec

hyf0
hyf0 reviewed Jan 18, 2025
View reviewed changes
@Boshen Boshen force-pushed the 01-18-feat_string_wizard_add_.haschanged_ branch from 688ff32 to b6e4f2c Compare January 18, 2025 11:06
@Boshen Boshen enabled auto-merge January 18, 2025 11:13
@Boshen Boshen added this pull request to the merge queue Jan 18, 2025
Merged via the queue into main with commit 0d33eef Jan 18, 2025
21 checks passed
@Boshen Boshen deleted the 01-18-feat_string_wizard_add_.haschanged_ branch January 18, 2025 11:27
@Boshen
Copy link
Member Author

Boshen commented Jan 18, 2025

@hyf0 can you publish a new version 🙇

@hyf0
Copy link
Member

hyf0 commented Jan 18, 2025

@Boshen Done 0.0.26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Boshen @hyf0