Skip to content

fix: should create one sourcemap if transform hook not return#3107

Merged
underfin merged 1 commit intomainfrom
fix-load-sourcemap
Dec 10, 2024
Merged

fix: should create one sourcemap if transform hook not return#3107
underfin merged 1 commit intomainfrom
fix-load-sourcemap

Conversation

@underfin
Copy link
Contributor

Description

Partially closed #3092. The oxc_sourcemap#lookup_source_view_token issue i will fix it at next.

@netlify
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit c0b9406
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6758143b3ab09d00081bffce

@github-actions
Copy link
Contributor

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.01     73.9±1.53ms        ? ?/sec    1.00     73.4±1.36ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     97.1±1.73ms        ? ?/sec    1.01     97.9±5.41ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.01    112.5±2.61ms        ? ?/sec    1.00    110.9±1.72ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.06     88.1±2.97ms        ? ?/sec    1.00     83.1±1.54ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    127.7±1.53ms        ? ?/sec    1.03    131.1±4.05ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    223.9±7.86ms        ? ?/sec    1.00    224.7±5.18ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    257.9±3.95ms        ? ?/sec    1.02    263.5±6.46ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    141.2±1.73ms        ? ?/sec    1.04    146.6±3.01ms        ? ?/sec
bundle/bundle@threejs                                               1.00     38.6±0.78ms        ? ?/sec    1.01     38.8±1.76ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.01     92.8±3.03ms        ? ?/sec    1.00     91.8±1.48ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    104.0±1.72ms        ? ?/sec    1.00    103.9±1.95ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     48.8±0.68ms        ? ?/sec    1.01     49.1±0.67ms        ? ?/sec
bundle/bundle@threejs10x                                            1.01   409.2±12.62ms        ? ?/sec    1.00    405.5±4.12ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1095.3±8.50ms        ? ?/sec    1.01   1103.2±6.64ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1304.1±9.25ms        ? ?/sec    1.01  1314.3±11.08ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    481.6±3.72ms        ? ?/sec    1.00    480.5±4.77ms        ? ?/sec
remapping/remapping                                                 1.00     29.1±0.27ms        ? ?/sec    1.00     29.0±0.28ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     76.0±1.07ms        ? ?/sec    1.01     76.7±0.31ms        ? ?/sec
scan/scan@rome-ts                                                   1.00    100.8±1.42ms        ? ?/sec    1.02    102.4±2.21ms        ? ?/sec
scan/scan@threejs                                                   1.00     29.3±1.65ms        ? ?/sec    1.06     30.9±1.97ms        ? ?/sec
scan/scan@threejs10x                                                1.00    295.8±4.09ms        ? ?/sec    1.00    294.9±4.30ms        ? ?/sec

@IWANABETHATGUY
Copy link
Member

if you want to partially closed that pr, you should not put a closed before a pr link, this pr will close the linked pr after merged, just a note, but if you intent to do that just ignore me.

@underfin underfin added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit b30cd89 Dec 10, 2024
@underfin underfin deleted the fix-load-sourcemap branch December 10, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Source map source content is a transformed code when { map: null }

3 participants