feat: don't normalize options on js side - part2#2848
Merged
hyf0 merged 1 commit intorolldown:mainfrom Nov 22, 2024
Merged
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
013d0d8 to
c50135b
Compare
c50135b to
64ca4c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #2835
I found that removing
normalizeInputOptionsis a bit tricky because it is tightly coupled with thePluginon the js side.I reviewed the context of issue #1041, but I'm still unsure if I'm on the right track. Therefore, I'm submitting this PR to ensure that what I'm doing is correct. I would appreciate it if you could point out the next steps I should take.