Skip to content

feat: don't normalize options on js side - part2#2848

Merged
hyf0 merged 1 commit intorolldown:mainfrom
shulaoda:feat/remove-options-normalization-on-js-side
Nov 22, 2024
Merged

feat: don't normalize options on js side - part2#2848
hyf0 merged 1 commit intorolldown:mainfrom
shulaoda:feat/remove-options-normalization-on-js-side

Conversation

@shulaoda
Copy link
Copy Markdown
Member

@shulaoda shulaoda commented Nov 21, 2024

Description

Related to #2835

I found that removing normalizeInputOptions is a bit tricky because it is tightly coupled with the Plugin on the js side.

I reviewed the context of issue #1041, but I'm still unsure if I'm on the right track. Therefore, I'm submitting this PR to ensure that what I'm doing is correct. I would appreciate it if you could point out the next steps I should take.

I also think about it before, we could using original external option to improve it. If the user not changed normalized external option, we just using original external option to binding option, it could be array|function.

I think about this too. But it requires us to change the definition of NormalizedInputOptions. If this is acceptable, we could just use InputOptions as the NormalizedInputOptions. I kind of feel that this makes the normalization step in js side meaningless, so I didn't propose this way.
Originally posted by @hyf0 in #1041

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 21, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 64ca4c4
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/673f4cb6fd7b8300084aa95c

@shulaoda shulaoda force-pushed the feat/remove-options-normalization-on-js-side branch from 013d0d8 to c50135b Compare November 21, 2024 15:07
@shulaoda shulaoda force-pushed the feat/remove-options-normalization-on-js-side branch from c50135b to 64ca4c4 Compare November 21, 2024 15:07
Copy link
Copy Markdown
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good works

@hyf0 hyf0 added this pull request to the merge queue Nov 22, 2024
Merged via the queue into rolldown:main with commit b73bbba Nov 22, 2024
@shulaoda shulaoda deleted the feat/remove-options-normalization-on-js-side branch November 22, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants