chore: add span of module_request in raw import record#1871
Merged
IWANABETHATGUY merged 4 commits intomainfrom Aug 5, 2024
Merged
chore: add span of module_request in raw import record#1871IWANABETHATGUY merged 4 commits intomainfrom
module_request in raw import record#1871IWANABETHATGUY merged 4 commits intomainfrom
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
hyf0
reviewed
Aug 5, 2024
| /// See [ImportRecord] for more details. | ||
| pub is_plain_import: bool, | ||
| pub module_request_start: u32, | ||
| pub import_record_meta: ImportRecordMeta, |
Member
There was a problem hiding this comment.
Suggested change
| pub import_record_meta: ImportRecordMeta, | |
| pub meta: ImportRecordMeta, |
Member
There was a problem hiding this comment.
If you think this might cause confusing with considering the meta word used in link stage. You could call it flags too.
IWANABETHATGUY
commented
Aug 5, 2024
| pub contains_import_default: bool, | ||
| /// If it is `import {} from '...'` or `import '...'` | ||
| pub is_plain_import: bool, | ||
| pub meta: ImportRecordMeta, |
Member
Author
There was a problem hiding this comment.
Span in ImportRecord is unused, so I don't pass it into ImportRecord
hyf0
approved these changes
Aug 5, 2024
Contributor
Benchmarks Rust |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
module_request.Spandirectly the type size will increase from40to48bytes.Related to #1866