Skip to content

chore: replace module id related type with arcstr#1870

Merged
IWANABETHATGUY merged 1 commit intomainfrom
chore/replace-module-id-with-arc-str
Aug 5, 2024
Merged

chore: replace module id related type with arcstr#1870
IWANABETHATGUY merged 1 commit intomainfrom
chore/replace-module-id-with-arc-str

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

@IWANABETHATGUY IWANABETHATGUY commented Aug 5, 2024

Description

  1. replace Arc<str> with ArcStr
  2. replace String with ArcStr
  3. Normalize type related to module id

related to #1866

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 5, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b3befe7
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66b0926dc3d9980008b2d0cb

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 5, 2024

Benchmarks Rust

  • target: main(f3d050a)
  • pr: chore/replace-module-id-with-arc-str(b3befe7)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.06     52.5±0.56ms        ? ?/sec    1.00     49.6±1.10ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     65.5±1.13ms        ? ?/sec    1.02     67.0±1.54ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     82.9±1.30ms        ? ?/sec    1.02     84.2±2.47ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     57.9±0.77ms        ? ?/sec    1.01     58.6±1.67ms        ? ?/sec
bundle/bundle@rome-ts                                               1.04     93.1±1.32ms        ? ?/sec    1.00     89.5±0.97ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.04    150.7±1.79ms        ? ?/sec    1.00    145.4±2.07ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.06    199.9±2.76ms        ? ?/sec    1.00    188.7±6.17ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.03    112.6±3.01ms        ? ?/sec    1.00    109.6±0.90ms        ? ?/sec
bundle/bundle@threejs                                               1.01     27.8±0.54ms        ? ?/sec    1.00     27.6±0.98ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.06     61.5±1.92ms        ? ?/sec    1.00     58.0±2.23ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.03     81.5±0.93ms        ? ?/sec    1.00     78.8±3.00ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.01     39.3±0.55ms        ? ?/sec    1.00     39.1±0.78ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    295.3±3.15ms        ? ?/sec    1.05    308.7±5.26ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00    668.8±6.99ms        ? ?/sec    1.00    667.7±5.30ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00    895.5±8.77ms        ? ?/sec    1.00    894.8±9.36ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    390.9±9.14ms        ? ?/sec    1.02    398.6±7.03ms        ? ?/sec
remapping/remapping                                                 1.00     34.8±0.22ms        ? ?/sec    1.01     35.3±0.15ms        ? ?/sec
remapping/render-chunk-remapping                                    1.02     83.1±0.38ms        ? ?/sec    1.00     81.7±0.42ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     71.5±0.86ms        ? ?/sec    1.02     72.6±0.89ms        ? ?/sec
scan/scan@threejs                                                   1.00     20.2±0.15ms        ? ?/sec    1.00     20.3±0.74ms        ? ?/sec
scan/scan@threejs10x                                                1.00    200.9±2.04ms        ? ?/sec    1.00    201.6±1.29ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit 3edfc40 Aug 5, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the chore/replace-module-id-with-arc-str branch August 5, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants