Skip to content

refactor: rename BuildError to BuildDiagnostic#1641

Merged
IWANABETHATGUY merged 2 commits into
mainfrom
chore/refactor-build-error
Jul 16, 2024
Merged

refactor: rename BuildError to BuildDiagnostic#1641
IWANABETHATGUY merged 2 commits into
mainfrom
chore/refactor-build-error

Conversation

@IWANABETHATGUY

@IWANABETHATGUY IWANABETHATGUY commented Jul 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

@netlify

netlify Bot commented Jul 16, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit ac3c344
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66964012269f1300088a00da

@IWANABETHATGUY IWANABETHATGUY force-pushed the chore/refactor-build-error branch from 38b5fa1 to 28047c8 Compare July 16, 2024 08:47
@hyf0

hyf0 commented Jul 16, 2024

Copy link
Copy Markdown
Member

Nice. I'm also thinking about a DiagnosticStore to replace raw errors warnings.

@github-actions

github-actions Bot commented Jul 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     48.0±0.69ms        ? ?/sec    1.03     49.4±1.24ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     57.3±0.42ms        ? ?/sec    1.01     58.1±1.04ms        ? ?/sec
bundle/bundle@rome-ts                                        1.00     93.5±1.86ms        ? ?/sec    1.03     96.3±1.66ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                              1.00    112.2±1.19ms        ? ?/sec    1.01    113.8±1.93ms        ? ?/sec
bundle/bundle@threejs                                        1.00     27.6±0.85ms        ? ?/sec    1.07     29.6±0.96ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     38.1±0.76ms        ? ?/sec    1.02     38.9±1.13ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    305.1±3.45ms        ? ?/sec    1.04    317.2±5.77ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    396.0±7.02ms        ? ?/sec    1.02    404.1±7.20ms        ? ?/sec
remapping/remapping                                          1.04     66.7±1.57ms        ? ?/sec    1.00     64.1±0.34ms        ? ?/sec
scan/scan@rome-ts                                            1.06     79.0±1.17ms        ? ?/sec    1.00     74.7±0.74ms        ? ?/sec
scan/scan@rome-ts-sourcemap                                  1.02     76.1±1.05ms        ? ?/sec    1.00     74.4±0.49ms        ? ?/sec
scan/scan@threejs                                            1.00     20.9±0.16ms        ? ?/sec    1.00     21.0±0.55ms        ? ?/sec
scan/scan@threejs-sourcemap                                  1.03     20.8±0.30ms        ? ?/sec    1.00     20.1±0.27ms        ? ?/sec
scan/scan@threejs10x                                         1.01    208.9±1.77ms        ? ?/sec    1.00    206.9±2.37ms        ? ?/sec
scan/scan@threejs10x-sourcemap                               1.00    206.1±2.01ms        ? ?/sec    1.01    207.5±2.76ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review July 16, 2024 09:22
@IWANABETHATGUY IWANABETHATGUY self-assigned this Jul 16, 2024
@IWANABETHATGUY

IWANABETHATGUY commented Jul 16, 2024

Copy link
Copy Markdown
Member Author

I don't think a simple renaming would lead to performance regression, so merged it first.

Nice. I'm also thinking about a DiagnosticSto

Let's merged it for now, and maybe improve in the future.

@IWANABETHATGUY IWANABETHATGUY enabled auto-merge July 16, 2024 09:24
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jul 16, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Jul 16, 2024
@IWANABETHATGUY IWANABETHATGUY force-pushed the chore/refactor-build-error branch from 28047c8 to ac3c344 Compare July 16, 2024 09:40
@IWANABETHATGUY IWANABETHATGUY enabled auto-merge July 16, 2024 09:43
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 77b107b Jul 16, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the chore/refactor-build-error branch July 16, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0