Skip to content

perf(rolldown): replace HASH_PLACEHOLDER_RE with simple string parsing#1496

Merged
hyf0 merged 2 commits intomainfrom
extra-hash-pattern
Jun 30, 2024
Merged

perf(rolldown): replace HASH_PLACEHOLDER_RE with simple string parsing#1496
hyf0 merged 2 commits intomainfrom
extra-hash-pattern

Conversation

@Boshen
Copy link
Copy Markdown
Member

@Boshen Boshen commented Jun 30, 2024

closes #1480

@netlify
Copy link
Copy Markdown

netlify bot commented Jun 30, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit ad8fb44
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/668136fea084ec0008908006

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 30, 2024 •
edited
Loading

Benchmarks Rust

group                                 pr                                     target
-----                                 --                                     ------
bundle/bundle@rome-ts                 1.00     94.5±0.97ms        ? ?/sec    1.01     95.5±1.18ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap       1.00    114.6±2.01ms        ? ?/sec    1.01    115.9±1.22ms        ? ?/sec
bundle/bundle@threejs                 1.00     28.3±0.91ms        ? ?/sec    1.05     29.7±2.03ms        ? ?/sec
bundle/bundle@threejs-sourcemap       1.00     35.9±0.96ms        ? ?/sec    1.08     38.8±0.82ms        ? ?/sec
bundle/bundle@threejs10x              1.00    303.8±3.24ms        ? ?/sec    1.02    309.6±7.54ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap    1.00   405.8±14.10ms        ? ?/sec    1.00    405.7±7.15ms        ? ?/sec
scan/scan@rome-ts                     1.00     77.2±0.87ms        ? ?/sec    1.00     76.9±0.79ms        ? ?/sec
scan/scan@rome-ts-sourcemap           1.00     76.3±0.86ms        ? ?/sec    1.02     77.6±0.75ms        ? ?/sec
scan/scan@threejs                     1.00     21.1±0.68ms        ? ?/sec    1.01     21.4±0.31ms        ? ?/sec
scan/scan@threejs-sourcemap           1.00     21.2±0.26ms        ? ?/sec    1.01     21.4±0.13ms        ? ?/sec
scan/scan@threejs10x                  1.00    210.1±1.78ms        ? ?/sec    1.01    211.6±3.23ms        ? ?/sec
scan/scan@threejs10x-sourcemap        1.00    209.0±1.44ms        ? ?/sec    1.00    209.5±1.72ms        ? ?/sec

hyf0
hyf0 approved these changes Jun 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@hyf0 hyf0 added this pull request to the merge queue Jun 30, 2024
Merged via the queue into main with commit aa347f5 Jun 30, 2024
@hyf0 hyf0 deleted the extra-hash-pattern branch June 30, 2024 16:55
@hyf0 hyf0 mentioned this pull request Sep 2, 2024
Closed
@shulaoda shulaoda mentioned this pull request Sep 15, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regex HASH_PLACEHOLDER_RE is bloated

2 participants

@Boshen @hyf0