fix: add return source logic when file not downloaded and add loader …#1287
Merged
IWANABETHATGUY merged 1 commit intoMay 30, 2024
Merged
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
IWANABETHATGUY
approved these changes
May 30, 2024
27294dd to
075cbda
Compare
Contributor
Author
|
sorry i dont have right to re_run workflow to check the change |
Contributor
Author
|
@IWANABETHATGUY please help me re_run this workflow ,i have no right to reboot it |
075cbda to
f50a39b
Compare
IWANABETHATGUY
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…suite
Description
in the old logic
when the script exec " return fs.readFileSync(sourcePath).toString()" and golang file not downloaded and happend exception
the logic will try to download file but not return the golang code source
i fix it and return the expect code
please review it thank you master and have nice day