-
Notifications
You must be signed in to change notification settings - Fork 710
Open
Description
Context
The WASI test pipeline was removed in the CI cleanup because it was effectively dead weight:
- PR chore(ci): ensure running wasi tests correctly #6154 (Sep 2025) rewrote
reusable-wasi-test.ymlbecause old tests ran with the native.nodebinding instead of WASI - After the rewrite, Node Test and Rollup Test steps were added with
if: false— they were never enabled - The only active step was "Build Basic Example" which ran on ubuntu/macos only (skipped on Windows)
- The Windows WASI test was a complete no-op — it spun up a runner and exited immediately
- The WASI build took ~4 min on average and produced an artifact only consumed by the mostly-disabled tests
What needs to happen
- Set up proper WASI test infrastructure with
NAPI_RS_FORCE_WASI=error - Enable the Node Test and Rollup Test steps that were disabled since the rewrite
- Ensure tests actually run against the WASI binding (not the native binding)
- Consider whether all 3 OS matrix entries (ubuntu, macos, windows) are needed for WASI testing
Notes
- The
Node Validationjob inci.ymlstill builds@rolldown/browserwhich needs the WASI target — that is separate and unaffected - The WASI build/test was not used by release or publish workflows
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels