Skip to content

[Bug]: Minify should keep comments in banner #3338

@sevenc-nanashi

Description

@sevenc-nanashi

Reproduction link or steps

Specify output.banner and output.minify.

import { defineConfig } from "rolldown";

export default defineConfig({
    input: ['./src/entry.js', './src/other-entry.js'],
    output: {
        banner: "/* I AM BANNER */",
        minify: true
    }
})

https://stackblitz.com/edit/github-rkxqfeat?file=dist%2Fentry.js

What is expected?

Comment should be kept:

/* I AM BANNER */
minifiedJsCodeHereminifiedJsCodeHereminifiedJsCodeHereminifiedJsCodeHere

What is actually happening?

Comment is deleted:

minifiedJsCodeHereminifiedJsCodeHereminifiedJsCodeHereminifiedJsCodeHere

System Info

❯ npx envinfo --system --npmPackages rolldown --binaries --browsers

  System:
    OS: Linux 5.0 undefined
    CPU: (6) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    rolldown: latest => 1.0.0-beta.1

Any additional comments?

N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions