Skip to content

version up logback #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seki-shinnosuke wants to merge 1 commit into from
Closed

version up logback #296

seki-shinnosuke wants to merge 1 commit into from

Conversation

@seki-shinnosuke
Copy link

@seki-shinnosuke seki-shinnosuke commented Oct 31, 2022

Description of the change

version up logback 1.2.3 -> 1.4.4

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@diegov
Copy link
Contributor

diegov commented Mar 10, 2023

Hi @seki-shinnosuke.

Unless there's a specific security reason, rollbar-java will add dependencies to the lowest possible version of the 3rd party libraries. As long as those libraries maintain backwards compatibility, this allows our users to pick the version, without rollbar-java forcing them to upgrade.

Is there a specific reason to upgrade logback in this case?

@christianbuon christianbuon mentioned this pull request May 4, 2024
Merged
12 tasks
@seki-shinnosuke seki-shinnosuke closed this by deleting the head repository May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seki-shinnosuke @diegov