Skip to content

Small code fixes#1

Merged
rohit-garga merged 7 commits into
rohit-garga:fix-for-issue-11251from
JabRef:improve-fix-for-issue-11251
Apr 29, 2024
Merged

Small code fixes#1
rohit-garga merged 7 commits into
rohit-garga:fix-for-issue-11251from
JabRef:improve-fix-for-issue-11251

Conversation

@koppor

@koppor koppor commented Apr 29, 2024

Copy link
Copy Markdown

Small code fixes for JabRef#11253

If you merge these, your PR should be ready to go.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@LoayGhreeb

Copy link
Copy Markdown

@koppor Shouldn't this PR push to the fix-for-issue-11251 branch instead of main?

@koppor koppor changed the base branch from main to fix-for-issue-11251 April 29, 2024 09:50
@koppor

koppor commented Apr 29, 2024

Copy link
Copy Markdown
Author

@LoayGhreeb You are right! Thank you for the hint! Fixed.

@rohit-garga rohit-garga merged commit 518de66 into rohit-garga:fix-for-issue-11251 Apr 29, 2024
@koppor koppor deleted the improve-fix-for-issue-11251 branch May 21, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants