Add support for nordpass import from nordpass csv#178
Add support for nordpass import from nordpass csv#178roddhjav merged 3 commits intoroddhjav:masterfrom shashwat183:add_nord_pass_manager
Conversation
|
Hi, thank for this PR. There are a few part to improve before I can merge it. The structure of |
|
Ok got it. I will make the required changes. |
|
That is still not good. When we do an export of Nordpass, we do not your modified CSV but your original one. The test needs to pass with this CSV as this is what the people exporting password from Nordpass will get. So lines such as |
|
Yepp i haven't written the parse method yet. I just did a rebase on master to incorporate all the recent changes made. I will be implementing the method to parse and remove the folder rows and updating the code soon. |
|
Hi, I have implemented the parse method with code to remove the folder entries from CSV data. That data is not really needed to identify folders because every secret/note has a folder column with the correct folder name. Identifying and removing those folder entries should be sufficient. Please let me know if anything else is needed. Cheers |
|
Good work. Merged. Thank again for your PR. |
This change adds support for importing data from Nord Pass Password Manager.
Nord Pass provides the ability to export all password data in CSV format which can be imported to pass using pass-import after this change.
All the docs have also been updated to reflect the change.
This is my first open-source contribution so any feedback would be welcome. Cheers