Skip to content

Add support for nordpass import from nordpass csv#178

Merged
roddhjav merged 3 commits intoroddhjav:masterfrom
shashwat183:add_nord_pass_manager
Jul 3, 2022
Merged

Add support for nordpass import from nordpass csv#178
roddhjav merged 3 commits intoroddhjav:masterfrom
shashwat183:add_nord_pass_manager

Conversation

@shashwat183
Copy link
Copy Markdown
Contributor

This change adds support for importing data from Nord Pass Password Manager.
Nord Pass provides the ability to export all password data in CSV format which can be imported to pass using pass-import after this change.
All the docs have also been updated to reflect the change.

This is my first open-source contribution so any feedback would be welcome. Cheers

@roddhjav
Copy link
Copy Markdown
Owner

roddhjav commented Jun 25, 2022

Hi, thank for this PR.

There are a few part to improve before I can merge it.

The structure of nordpass.csv cannot be changed (as you did in 8bace4d). Nordpass might have a weird way to define folders, it is up to pass-import to understand it. So you need to implement this in a parse method.

@shashwat183
Copy link
Copy Markdown
Contributor Author

Ok got it. I will make the required changes.

@roddhjav
Copy link
Copy Markdown
Owner

roddhjav commented Jun 26, 2022

That is still not good. When we do an export of Nordpass, we do not your modified CSV but your original one. The test needs to pass with this CSV as this is what the people exporting password from Nordpass will get. So lines such as Social,,,,,,,,,,,,,,,,,, must stay, as it is Nordpass' way to define folder.

@shashwat183
Copy link
Copy Markdown
Contributor Author

Yepp i haven't written the parse method yet. I just did a rebase on master to incorporate all the recent changes made. I will be implementing the method to parse and remove the folder rows and updating the code soon.

@shashwat183
Copy link
Copy Markdown
Contributor Author

Hi,

I have implemented the parse method with code to remove the folder entries from CSV data. That data is not really needed to identify folders because every secret/note has a folder column with the correct folder name. Identifying and removing those folder entries should be sufficient.

Please let me know if anything else is needed.

Cheers

@roddhjav
Copy link
Copy Markdown
Owner

roddhjav commented Jul 3, 2022

Good work. Merged. Thank again for your PR.

@roddhjav roddhjav merged commit cce1517 into roddhjav:master Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants