setup: make pimport a setuptools script#138
Merged
roddhjav merged 1 commit intoroddhjav:masterfrom Mar 22, 2021
Merged
Conversation
Owner
|
Thanks, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pimportscript seems redundant if using thesetuptools-based console scripts: https://setuptools.readthedocs.io/en/latest/userguide/entry_point.html#console-scriptsThis PR changes
pass-importto use that convention.I'm open to suggestions as to what I'm missing about
pimport's usage, but it seems to me that theentry_pointscommand is better-supported thanscripts, and it saves having a redundant file.In a specific use-case, on NixOS/nixpkgs, the
scriptsoption is actually NOT desired, because thepimportscript is simply copied and then needs to be manually wrapped to recognize the python environment, instead of using the built-in infrastructure for handlingentry_points. See NixOS/nixpkgs#117165.