Add Libs.private to autoconf libpsl.pc#246
Merged
rockdaboot merged 1 commit intorockdaboot:masterfrom May 9, 2024
Merged
Conversation
eli-schwartz
approved these changes
May 6, 2024
Collaborator
eli-schwartz
left a comment
There was a problem hiding this comment.
lgtm
I would personally reorganize it so the two Libs lines are together but that's just a nit.
Static libraries don't include dependency information, so when using pkg-config to find out how to link with a static library, the .pc file for that library has to specify what other libraries to link. Libs.private is like Libs, except it's only used when static linking. This fixes linking against a static libpsl using pkg-config. The Meson-generated libpsl.pc just includes all of its dependent libraries in Libs, so doesn't require any additional fix.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static libraries don't include dependency information, so when using pkg-config to find out how to link with a static library, the .pc file for that library has to specify what other libraries to link. Libs.private is like Libs, except it's only used when static linking. This fixes linking against a static libpsl using pkg-config.
The Meson-generated libpsl.pc just includes all of its dependent libraries in Libs, so doesn't require any additional fix.