Skip to content

Cards description#94

Merged
rochacbruno merged 1 commit intorochacbruno:mainfrom
rdenadai:repeated-title-annoyance-complex
Oct 29, 2024
Merged

Cards description#94
rochacbruno merged 1 commit intorochacbruno:mainfrom
rdenadai:repeated-title-annoyance-complex

Conversation

@rdenadai
Copy link
Copy Markdown
Contributor

@rdenadai rdenadai commented Oct 29, 2024

@rochacbruno this an attempt to make it possible the description for the cards in the list.html.

I added a description to the Content struct, that could get filled with values in a description, if None we just fallback to the previous way (get from html and strip everything).

rochacbruno
rochacbruno requested changes Oct 29, 2024
View reviewed changes
@rochacbruno
Copy link
Copy Markdown
Owner

rochacbruno commented Oct 29, 2024

The example dir is being our functional test, can you please add description to at least one of the posts on https://github.com/rochacbruno/marmite/tree/main/example/content so we can see it in action and ensure it does not break.

The example is build on CI for every PR.

@rdenadai rdenadai force-pushed the repeated-title-annoyance-complex branch from 07e5476 to e2d6dc7 Compare October 29, 2024 14:35
@rdenadai
Copy link
Copy Markdown
Contributor Author

rdenadai commented Oct 29, 2024

The example dir is being our functional test, can you please add description to at least one of the posts on https://github.com/rochacbruno/marmite/tree/main/example/content so we can see it in action and ensure it does not break.

The example is build on CI for every PR.

Changed one of the templates inside example adding the description props...
https://github.com/rochacbruno/marmite/pull/94/files#diff-ed8d8eb0f5910129e1c418a133c868185f804343e9a303ef662ce4eb1115776cR5

@rdenadai rdenadai requested a review from rochacbruno October 29, 2024 14:37
@rochacbruno rochacbruno merged commit 4593064 into rochacbruno:main Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rochacbruno rochacbruno rochacbruno approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rdenadai @rochacbruno