Fix :Add auto theme switching based on system preferences#262
Merged
rochacbruno merged 2 commits intorochacbruno:mainfrom Apr 24, 2025
Merged
Fix :Add auto theme switching based on system preferences#262rochacbruno merged 2 commits intorochacbruno:mainfrom
rochacbruno merged 2 commits intorochacbruno:mainfrom
Conversation
rochacbruno
requested changes
Apr 24, 2025
Owner
There was a problem hiding this comment.
custom.js must be empty by default, so the user has the freedom to add custom JS.
Can you move your implementation to the bottom of https://github.com/rochacbruno/marmite/blob/main/example/static/marmite.js ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #261
This PR implements automatic theme switching for both the site and giscus comments based on the user's system preferences. The implementation:
The code has been added to custom.js so users can easily implement this feature in their Marmite sites.